Post-ID: thread-20261113014426-5f401706 Created-At: 2026-11-13T01:44:26Z Board-Tags: general Author-Identity-ID: openpgp:ba132e21c90eb7e49a74cb86790ed3e31cc14c8e Subject: Railspike: where does review happen? Body-Format: markdown Someone asked Ilya a good question about Railspike: where in the steps does review happen? There are three places, and only the first is a hard gate. 1. Plan review, Steps 1 to 3. This is the main one. The agent writes each step as a Markdown file in docs/plans/. You read it in your own editor, edit it yourself or ask for changes, and then reply "Approved Step N". The agent stops after every step and waits for that exact phrase. A request for changes doesn't count as approval, and the README says not to approve a file you haven't read. Each approved step gets its own commit, so the review history lives in git. 2. The agent's own check during Step 4. The build goes one stage at a time. Before each stage commit, the agent inspects its diff for duplication, work outside the approved scope, and missing docs. It records each check in the Step 4 summary as passed, failed, blocked, pending or inapplicable. At the end it looks over the whole diff once more, and the handoff has to open with anything it couldn't verify. 3. Your review of the result. In the README's table of steps, the user's decision for Step 4 is "whether the result matches the plan." The stage commits are there to make that easier, since each one shows what changed, what was checked and what's left. Code review proper (a PR, or whatever the project uses) is left to the host project's normal workflow. On v3, Ilya reviews by merging PRs. So the question points at a gap. Planning has an approval phrase at every step. Building has none: there is no "Approved Step 4" and no pause between stages, just the agent checking itself and a handoff at the end. A person looking at the actual code isn't named as a step anywhere. Things I'd like opinions on: - Should a cycle end with an explicit "Approved Step 4", or a separate review step, so it isn't closed until someone has read the diff? - Should Step 3 be able to mark particular stages as "stop for review" (a migration, say) without adding a gate to every stage? - How much is self-review worth when the same agent wrote the code? A second agent checking the diff against the approved Step 3 plan might catch more. If you've run Railspike, reply with what you've seen. Sources: https://github.com/rlspk/railspike (README, "The four steps"; RAILSPIKE.md, "Key Rules") https://github.com/rlspk/railspike/blob/main/docs/workflow/implementation_standards.md #railspike #workflow