Fix bookmarklet percent-sign errors with POST draft intake
Issue: Bookmarklet clips containing a percent sign fail before the composer opens
Status: Diagnosed; implementation instructions only
Constraint: Hosting cannot be changed. Fix the bookmarklet transport and its application-side draft intake.
Related feedback: PF-20261030-B15 (long bookmarklet URLs); this incident has a different confirmed trigger.
Diagnosis:
The supplied Emacs article clip failed at 2026-11-15 13:04:25 and 13:04:28 PST. The HTTPS access log records HTTP 418. Matching error-log entries show ModSecurity rules 920220 and 920221 reporting invalid URL encoding, followed by rule 949110 blocking with anomaly score 10 against threshold 7. The logged ruleset is OWASP_CRS/4.7.0-dev.
The trigger is the percent sign in "85-90% of use cases", correctly encoded as 85-90%25%20of%20use%20cases. The original request target is only 758 bytes and contains no malformed percent escapes. Replaying the full URL reproduced the block. Replacing only %25 with %20percent returned HTTP 200. Minimal reproduction:
https://zenmemes.com/compose/thread?body=85-90%25%20of%20use%20cases
The minimal reproduction also failed, while body=85-90%20percent%20of%20use%20cases returned 200. Curl received a generic 500 page during these replays; the corresponding server error log still recorded the underlying 418 ModSecurity denial. The precise reason for that status-page discrepancy was not established.
This is a firewall false positive on correctly encoded text. The upstream 4.7.0 rules decode before URL-encoding validation, consistent with treating a decoded literal percent sign as another escape. The installed host rules were not inspected directly. Reference:
https://github.com/coreruleset/coreruleset/blob/v4.7.0/rules/REQUEST-920-PROTOCOL-ENFORCEMENT.conf
Fix instructions:
Change bookmarklets to submit the clip in a normal HTML form POST body to a short, fixed same-origin destination, for example POST /compose/thread/prefill. Keep subject, body and board_tags out of the query string. Create fields using DOM APIs and assign their values directly; let the browser encode the form. Preserve the original percent sign, newlines, source URL and Unicode. Do not double-encode, delete or silently rewrite text. Do not move encoded content into a fragment or opaque token.
Add a dedicated, non-publishing draft-intake route in src/ForumRewrite/Application.php and src/ForumRewrite/Http/ComposeAndAccountKeyController.php. The existing POST /compose/thread submits a post, so changing only the bookmarklet's HTTP method would be unsafe. The new route must only parse the allowed scalar prefill fields and render the existing composer. It must not invoke a writer, sign, register an identity or publish. Use the existing request parser, field limits, escaping, access gates and shared composer; reject malformed inputs clearly. Serve this request-specific response with no-store caching. Keep existing GET compose links working.
Reuse renderComposeThreadPage(), templates/pages/compose_thread.php and templates/partials/thread_compose_form.php. The returned form must still publish through its existing explicit Post action. Avoid a parallel composer or a redirect that puts the clip back in the URL.
Update public/assets/tools_bookmarklets.js for the shared clip/selection/URL and tweet paths, retaining supported same-window and new-window modes and drag/copy behavior. A normal cross-origin form navigation does not require a CORS API. Source-page CSP form-action and popup restrictions can still block it: preserve the captured text and provide a copy/manual-paste recovery path. Do not report success merely because a new window opened. Do not retry through the old content-bearing GET URL.
Update explicit-prefill detection in public/assets/browser_signing.js. hasExplicitComposePrefill() currently only reads window.location.search. A POST-prefilled composer needs an explicit server-rendered prefill marker so stale local drafts or recently-cleared draft handling cannot overwrite the new clip. Preserve existing Back, retry and draft recovery behavior; do not clear unrelated unsent work silently.
Use the existing asset fingerprint/build workflow. Explain that previously saved bookmarklets contain the old code and must be replaced from the Bookmarklets page after deployment. Adding a new intake endpoint alone cannot repair those old URLs before the firewall sees them.
Acceptance and recovery:
First prove the proposed form encoding passes this unchanged hosting firewall. A local PHP test alone cannot establish that. POST intake is proposed, not yet verified on this host.
Run the original selected article text through the updated bookmarklet, with its percent sign intact. Confirm an editable draft, exact subject/body/tags and zero publications until Post is pressed. Then verify one publication through the ordinary composer on a test instance.
Cover percent signs in titles and bodies, literal percent-escape-looking text, ampersands, plus signs, newlines, Unicode and long clips. This transport also avoids the request-line limit from PF-20261030-B15, but request-body limits still need actionable recovery without truncation.
Exercise current/new-window modes, copied and dragged bookmarklets, stale drafts, recently-cleared drafts, Back/reload, blocked popup/form submission, validation failure and retry. Check signed/keyless posting and the composer with JavaScript disabled after intake; the bookmarklet itself requires JavaScript.
Extend LocalAppSmokeTest::testToolsPageRendersBookmarkletsAndComposeThreadAcceptsPrefills and the existing tests/browser/bookmarklet_copy* coverage. Run the smoke set plus affected tests only. Verify phone/desktop and affected themes/shared consumers; no new navigation destination is required.
Verification so far: Read-only live GET reproductions and source/log inspection. No application or hosting change was made. No automated suite was run; the full suite was not run. Implementation, POST-through-host verification and end-to-end browser acceptance remain pending.