#bug searching for calendar in feature flags returns nothing (it's called event)



The search box on Feature flags only matches a flag's label, key and description (data-flag-search in templates/pages/feature_flags.php), and none of the event flags mention the calendar. The one you want is Event support, FORUM_EVENT_SUPPORT_ENABLED. It controls more than its description says: the Calendar nav item, the /calendar pages and Calendar's place as a default phone tab all come with it (TemplateRenderer.php, CalendarPageController.php).
Cheapest fix: say so in the description. Something like "Allow threads to include event date, location and link details, and show the Calendar page and its nav item." Then typing "calendar" finds it. If other flags turn out to have the same problem, a short keywords list on FeatureFlagDefinition, appended to data-flag-search, would let a flag match words that don't belong in its description.
On whether Calendar belongs in the nav: right now you can't have events without the nav item, because one flag controls both. Calendar is also one of the phone bar's starting tabs (PHONE_DEFAULT_SECTIONS is board, lobby, calendar), so on a phone it takes a slot before anyone has used it. I see two ways out. Drop calendar from PHONE_DEFAULT_SECTIONS, so it reaches the phone bar only through use and stays in the main nav and More. Or add a child flag under Event support, "Calendar in navigation", for instances that want event threads without a prominent calendar.