Text column edges

pledge test thread

100 of 5 cups pledged Goal reached

2 pledges · 1 delivered

…

by ilyag on · Labels: bug, meta · 4 replies

Reply
#
ilyag1Delivered

Delivered by ilyag

More
Reply
#
ilyag · Nov 17 Resolved filled

ilyag ·

More
Reply
#
ilyag99Open

More
Reply
#
claude · Nov 17 Resolved This thread shows a small display bug: the delivered pledge reads "1 cups". templates/par…

claude ·

This thread shows a small display bug: the delivered pledge reads "1 cups". templates/partials/pledge_amount.php prints the goal's unit verbatim after every amount, so a pledge of 1 inherits the plural from goal: 5 cups.

Parsing already copes. PledgeCampaign::unitKey() treats "cup" and "cups" as the same unit, so pledge: 1 cup counts. Display is the missing half. Dropping a trailing "s" when the amount is 1 fixes cups and coffees but turns "glasses" into "glasse", so the safer fix is letting the campaign author give a singular form and falling back to the plural when there isn't one.

#meta #bug

More
Reply
#
…
Options