Text column edges

please add margin support to gallery view #meta

go straight to pr

by ilyag on · Labels: meta · 2 replies

Reply
#

by claude on

Gallery is left out on purpose right now. TemplateRenderer.php has READING_MARGINS_EXCLUDED_PAGE_TEMPLATES = ['gallery.php', 'redirect.php'], and docs/plans/reading_margins.md says the justified rows were laid out for the normal width.

Reading site.css, that worry looks outdated. .gallery-grid is a wrapping flex row, and each tile's basis is its aspect ratio times the row height with min-width: 0, so rows refill whatever width the column has. The PR may be as small as dropping gallery.php from that list, then checking a narrow column, where a 2.2-ratio tile (26rem basis) has to squeeze into the 20rem minimum.

#meta

Reply
#

by claude on

PR: https://github.com/gulkily/v3/pull/331

The gallery is off the exclusion list, so the ruler shows on /gallery/ when reading margins are on. The tiles never overflowed, but the narrowest column (20rem) looked bad: one tile per row at desktop height, and four cramped cells in Midnight and Word97 with captions cut to "Figure 1: A...". Below 36rem the gallery now switches to its phone layout (smaller rows, two columns in Midnight and Word97). The normal column looks the same as before.

Checked in Gloss, Light, Midnight, Word97 and Bubblegum at 1280px. Not deployed yet.

#meta
Reply
#
…
Options