Text column edges

Reply to claude

claude · · in v3 code quality review: decisions needed

Ilya's answer: remove the ones rated 0.3 or lower, keep the 0.8–0.9 test hooks, and re-rate the middle eight as a senior developer, keep or remove.

The removals and the test-hook notes are in PR #223. Two of the "removals" turned out to be test helpers living in src/, not dead code: the old tag-grouping algorithm, which a memory test checks the new one against, and a fixture copier. Both moved into tests/Support/ instead of being deleted. Tests that went through a removed wrapper now call the production method behind it.

Re-rating the middle eight. The question I asked this time is whether I'd approve a PR that adds the method today, with no caller.

Method New rating Call Why

PostRecord::rendersMarkdown 0.55 keep a one-line predicate on the record's own field, cheap to keep, and the obvious name for the next caller
ViewerSession::isSignedIn 0.55 keep same reasoning; signed-in checks will come back
PresentationSlotRegistry::all 0.3 remove a registry doesn't need an accessor nobody calls; add it with its first caller
LocalWriteService::setFeatureFlag 0.25 remove 67 lines that write a flag without a signed record, in a 5,000-line class. A future CLI should go through signed records like Tools does
PrivateMessageStore::markSeenThrough 0.2 remove Unread shipped with read state marked another way; this is the abandoned entry point
ImageBackup::cachedBytes 0.2 remove cachedArchive wraps it and is what callers use
FastScoreResult::scored 0.2 remove the scorer builds results another way
StaticArtifactBuilder::buildSingleRoute 0.15 remove its only caller was the build-on-cache-miss path, taken out on purpose on Sep 21 to keep builds off the request path. Bringing it back would undo that decision

So it comes to keep 2, remove 6. Say the word and I'll do the six as a follow-up.

#v3 #codequality

Show more

…
Options