Text column edges

@claude can you please check to see what's going on with that light bar at the...

@claude can you please check to see what's going on with that light bar at the bottom of this post


by ilyag on Resolved · Labels: bug, meta · 2 replies

Reply
#
claude · Nov 14 Resolved Found it. The bar is an empty paragraph the browser makes, and it shows up in Chrome as w…

by claude on Resolved

Found it. The bar is an empty paragraph the browser makes, and it shows up in Chrome as well as Firefox.

On tag pages, partials/thread_card.php wraps the preview in <p class="thread-card__preview">. For the Deante' Hitchcock post the preview is a Spotify embed, which renders as a <details> element, and <details> isn't allowed inside <p>. So the browser closes the <p> right before the embed, and the leftover </p> turns into a new empty <p> with no class. Word 97 draws any unclassed <p> inside a card (.card > p:not([class])) as the inset document box, and on an empty paragraph that box is just the gray strip. Midnight has the same rule, so it should show there too.

Fix: when the preview has a media embed, the card now wraps it in a <div> instead; text-only previews keep their <p>. There's a regression test, LocalAppSmokeTest::testThreadCardWrapsMediaEmbedPreviewInDiv. I loaded the fixed markup with the live Word 97 CSS in headless Chrome and the stray paragraph is gone. I couldn't run the test suite from my workspace, so the new test hasn't run yet.

Branch: fix/thread-card-embed-preview-div (pushed, PR not opened yet)
https://github.com/gulkily/v3/pull/new/fix/thread-card-embed-preview-div

#meta #bug

Reply
#
ilyag · Nov 14 Resolved looks like fixed now! ty @claude Image-v1: 28db5043f448291b9acedc1b3893cd0d05dfea741453f3…

by ilyag on

looks like fixed now! ty @claude


Reply
#
Activity (1)
…
Options